TRUNK-5085 Add checkstyle rule UnusedImports
we already flag unused imports using codacy but the rule is currently
manually configured in the codacy UI using the PMD checker.
* add the checkstyle rule which flags introduction of UnusedImports as
error so we keep the style in the repository and do not rely on manual
configurations in codacy
Merge pull request #2029 from teleivo/TRUNK-5085 TRUNK-5085 Merge checkstyle rules with google's
teleivo <mrteleivo@gmail.com>
1684758d8c6ecf0feb3fd94b67107feee0ef6b78
TRUNK-5085 Merge checkstyle rules with google's
merged our existing checkstyle.xml with google's
* removed their checks for tabs since we use tabs
* added NPathComplexity since it was already actived on codacy
* added CustomImportOrder rule using the Eclipse defaults
* changed the default severity to warning
* explicitly set the severity of rules we had before to error
* MagicNumber is an error but ignored for annotations
* reduced NestedIfDepth to 4 since that smells
* reduced NestedTryDepth to 2 since that smells
Merge pull request #2025 from mekomsolutions/2.1_TRUNK-5077 TRUNK-5077: AbstractHandler doesn't fail to purge obs with missing file.
mks-d <dimitri@mekomsolutions.com>
87b6e4c062fd0f9545c5c34c4200943ce9a2962a
TRUNK-5077: AbstractHandler doesn't fail to purge obs with missing file.
modified: api/src/main/java/org/openmrs/obs/handler/AbstractHandler.java
This unit test was throwing an APIException prior to the change.
modified: api/src/test/java/org/openmrs/api/ObsServiceTest.java
