Build #1,762

Plan branch:

Build: #1762 was successful

Job: Default Job was successful

Stages & jobs

  1. Default Stage

Code commits

openmrs-core master

  • JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com>

    JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com> 49736ff78d46cf4aae5a621f887c09b18d10ddf6

    GCI-142 Check bad code practices through Findbugs or Sonar and fix them (#2756)

    • api/src/main/java/org/openmrs/Allergy.java (version 49736ff78d46cf4aae5a621f887c09b18d10ddf6)
  • JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com>

    JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com> acd49ef5b57361a1df1209060bc110db0d092f63

    GCI-142 Check bad code practices through Findbugs or Sonar and fix them. (#2757)

    • api/src/main/java/org/openmrs/Concept.java (version acd49ef5b57361a1df1209060bc110db0d092f63)
    • api/src/main/java/org/openmrs/ConceptName.java (version acd49ef5b57361a1df1209060bc110db0d092f63)
    • api/src/main/java/org/openmrs/ConceptSet.java (version acd49ef5b57361a1df1209060bc110db0d092f63)
    • api/src/main/java/org/openmrs/Obs.java (version acd49ef5b57361a1df1209060bc110db0d092f63)
    • api/src/main/java/org/openmrs/Patient.java (version acd49ef5b57361a1df1209060bc110db0d092f63)
    • api/src/main/java/org/openmrs/Person.java (version acd49ef5b57361a1df1209060bc110db0d092f63)
    • api/src/main/java/org/openmrs/Role.java (version acd49ef5b57361a1df1209060bc110db0d092f63)
  • JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com>

    JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com> 7dbe2962603f1e4cc9a8e2d06d0e1d5e149e16b1

    GCI-142 Check bad code practices through Findbugs or Sonar and fix them (#2755)

    • api/src/main/java/org/openmrs/ConceptProposal.java (version 7dbe2962603f1e4cc9a8e2d06d0e1d5e149e16b1)
  • JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com>

    JyothsnaAshok <34093139+JyothsnaAshok@users.noreply.github.com> 5f2cf455123438a6910143c133bcc6accbbf3030

    GCI-142 Check bad code practices through Findbugs or Sonar and fix those issues. (#2744)
    Using Collection.isEmpty() makes the code more readable. Also the time complexity of any isEmpty() method implementation should be 0(1) whereas some implementations of size() can be 0(n).

  • Fungucide Fug Not Again <bluestich227@gmail.com>

    Fungucide Fug Not Again <bluestich227@gmail.com> b2dd6f36893870d973a4cb53c8d0af6bef835c63

    GCI-142: Fixed bad coding practices (#2750)

    • api/src/main/java/org/openmrs/api/OrderContext.java (version b2dd6f36893870d973a4cb53c8d0af6bef835c63)
  • Fungucide Fug Not Again <bluestich227@gmail.com>

    Fungucide Fug Not Again <bluestich227@gmail.com> 08e4f656ea0c1c100b1a953323cfc4a4d3627ef3

    GCI-142: Fixed bad coding practices (#2751)

    • api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientDAO.java (version 08e4f656ea0c1c100b1a953323cfc4a4d3627ef3)
  • Fungucide Fug Not Again <bluestich227@gmail.com>

    Fungucide Fug Not Again <bluestich227@gmail.com> d7bc370d22be69b58ecbd78a4ebcfa0c618b127a

    TRUNK-5435: Changed Stream Usage for Cohort.java (#2734)
    Changed stream usage to filter->findFirst->get. Error handling might need to be changed as the function now returns a NoSuchElement error instead of the previous IndexOutOfBound. I'm still waiting for a response from a mentor on how I should deal with this issue.

    • api/src/main/java/org/openmrs/Cohort.java (version d7bc370d22be69b58ecbd78a4ebcfa0c618b127a)