Build #217

Plan branch:

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 7f8602a6bb5465d0412b776cb8c2006675f3f647

    Merge pull request #288 from teleivo/RAD-174
    RAD-174 clean smells

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 3e1d1d259b90c5bc62f531f792df04cd24c0cd88

    RAD-174 clean smells
    * declare variables as final if only assigned once
    * remove reflection code in RadiologyStudy.toString()
    * remove useless parenthesis
    * inline some temp vars
    * add private constructor to utility classes
    * remove unnecessary ternary operator on expressions that already return
    required boolean

    • api/src/main/java/org/openmrs/module/radiology/RadiologyConstants.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/RadiologyPrivileges.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/RadiologyProperties.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/RadiologyRoles.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/order/HibernateRadiologyOrderDAO.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyDiscontinuedOrderValidator.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderServiceImpl.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderValidator.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/report/HibernateRadiologyReportDAO.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportServiceImpl.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportValidator.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/study/HibernateRadiologyStudyDAO.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/main/java/org/openmrs/module/radiology/study/RadiologyStudy.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • api/src/test/java/org/openmrs/module/radiology/study/RadiologyStudyTest.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/PatientDashboardRadiologyTabPortletController.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/PortletsController.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/RadiologyOrderFormController.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)
    • omod/src/main/java/org/openmrs/module/radiology/report/web/RadiologyReportFormController.java (version 3e1d1d259b90c5bc62f531f792df04cd24c0cd88)