Build #252

Plan branch:

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 502a5c9afcc703d393850a298aeb33b34e790319

    Merge pull request #327 from teleivo/RAD-289
    RAD-289 Cannot discontinue order

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> ef62f7d131359248d84593d43b640d791c66c882

    RAD-289 Cannot discontinue order
    Discontinuation of order fails via order form if accessing the page via UUID.
    Somehow spring sets the orderId of the discontinuationOrder modelAttribute to this UUID
    which causes a type cast error probably rooting in the PropertyEditor of the order. Therefore
    BindingResults hasErrors.

    * add DiscontinuationOrderRequest to encapsulate discontinuation orderer and
    reason
    * revamp old validator to DiscontinuationOrderRequestValidator
    * use validator in RadiologyOrderFormController via @Valid annotation
    * add test for postDiscontinueRadiologyOrder if discontinuation request was not
    valid

    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyDiscontinuedOrderValidator.java (version ef62f7d131359248d84593d43b640d791c66c882)
    • api/src/test/java/org/openmrs/module/radiology/order/RadiologyDiscontinuedOrderValidatorTest.java (version ef62f7d131359248d84593d43b640d791c66c882)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/DiscontinuationOrderRequest.java (version ef62f7d131359248d84593d43b640d791c66c882)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/DiscontinuationOrderRequestValidator.java (version ef62f7d131359248d84593d43b640d791c66c882)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/RadiologyOrderFormController.java (version ef62f7d131359248d84593d43b640d791c66c882)
    • omod/src/main/webapp/orders/radiologyOrderDiscontinuationSegment.jsp (version ef62f7d131359248d84593d43b640d791c66c882)
    • omod/src/test/java/org/openmrs/module/radiology/order/web/DiscontinuationOrderRequestValidatorTest.java (version ef62f7d131359248d84593d43b640d791c66c882)
    • omod/src/test/java/org/openmrs/module/radiology/order/web/RadiologyOrderFormControllerTest.java (version ef62f7d131359248d84593d43b640d791c66c882)