Build #329

Plan branch:

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> f919efbbd8f6940a86659fe594216857f615aae6

    Merge pull request #412 from teleivo/RAD-303
    RAD-303 Rethink exceptions of API

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 42199881d858a646c1afd092b48622063bbfb0fb

    RAD-303 Rethink exceptions of API
    throw openmrs APIException in service methods for cases violating business rules, and IllegalArgumentException for cases that are programming errors.
    APIExceptions are thrown using message codes from the message properties files, so the client code can catch those and display the error message to the user.

    * RadiologyStudyService.saveRadiologyStudy() does not allow saving existing
    * use throw APIException in RadiologyOrderServie.placeRadiologyOrder() and
    discontinueRadiologyOrder()
    * catch APIException in RadiologyOrderFormController.saveRadiologyOrder()
    * reduce code in catch block in
    RadiologyOrderFormController.saveRadiologyOrder() only to the service call
    * return in save/discontinueRadiologyOrder in controller after redirect since
    model objects in model and view will not be used.

    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderService.java (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderServiceImpl.java (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • api/src/main/java/org/openmrs/module/radiology/study/RadiologyStudyService.java (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • api/src/main/java/org/openmrs/module/radiology/study/RadiologyStudyServiceImpl.java (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • api/src/test/java/org/openmrs/module/radiology/order/RadiologyOrderServiceComponentTest.java (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • api/src/test/java/org/openmrs/module/radiology/study/RadiologyStudyServiceComponentTest.java (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • omod/src/main/java/org/openmrs/module/radiology/order/web/RadiologyOrderFormController.java (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • omod/src/main/resources/messages.properties (version 42199881d858a646c1afd092b48622063bbfb0fb)
    • omod/src/test/java/org/openmrs/module/radiology/order/web/RadiologyOrderFormControllerTest.java (version 42199881d858a646c1afd092b48622063bbfb0fb)