Build #131

Plan branch:

Build: #131 was successful

Job: Release to maven did not start

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> e66ded322900894b5186e1cf2e1f031bed2e41b3

    Merge pull request #193 from teleivo/RAD-174
    RAD-174 Cleanup smells and style

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 714c62c28c51fb28a1c7885477422c4b2071622c

    RAD-174 Cleanup smells and style
    * remove unused imports
    * use final if variables are only assigned once
    * add class javadocs to utility classes
    * add private constructor for utility classes with only static methods
    * use ! isEmpty() instead of size() > 0 on collections
    * avoid if/else statements without curly braces
    * remove some magic numbers
    * make class member a local variable if only used in one method
    * use constants for request mapping and view and use class level requestmapping
    * declare logger as private static final in classes

    • api/src/main/java/org/openmrs/module/radiology/DicomUtils.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/RadiologyActivator.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/RadiologyOrder.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/RadiologyProperties.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/Study.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/db/StudyDAO.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/db/hibernate/RadiologyOrderDAOImpl.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/db/hibernate/RadiologyReportDAOImpl.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/db/hibernate/StudyDAOImpl.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/HL7Utils.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/custommodel/v231/message/ORM_O01.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/custommodel/v231/segment/ZDS.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/message/RadiologyORMO01.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/segment/RadiologyMSH.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/segment/RadiologyOBR.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/segment/RadiologyORC.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/segment/RadiologyPID.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/hl7/segment/RadiologyZDS.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/impl/RadiologyServiceImpl.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/utils/DateTimeUtils.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/validator/RadiologyDiscontinuedOrderValidator.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/validator/RadiologyOrderValidator.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • api/src/main/java/org/openmrs/module/radiology/validator/RadiologyReportValidator.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/main/java/org/openmrs/module/radiology/web/controller/PortletsController.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/main/java/org/openmrs/module/radiology/web/controller/RadiologyDashboardController.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/main/java/org/openmrs/module/radiology/web/controller/RadiologyOrderFormController.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/main/java/org/openmrs/module/radiology/web/controller/RadiologyOrderListController.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/main/java/org/openmrs/module/radiology/web/controller/RadiologyReportFormController.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/main/java/org/openmrs/module/radiology/web/extension/html/AdminList.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/test/java/org/openmrs/module/radiology/web/controller/RadiologyOrderFormControllerTest.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)
    • omod/src/test/java/org/openmrs/module/radiology/web/controller/RadiologyReportFormControllerTest.java (version 714c62c28c51fb28a1c7885477422c4b2071622c)