Build #271

Plan branch:

Build: #271 was successful

Job: Release to maven did not start

Stages & jobs

  1. Default Stage

  2. Release

    Requires a user to start manually

Code commits

Git

  • Ivo Ulrich <teleivo@users.noreply.github.com>

    Ivo Ulrich <teleivo@users.noreply.github.com> 861b4fbdbffe021a63651222fa29558ab082d74d

    Merge pull request #349 from teleivo/RAD-332
    RAD-332 Fix Transactions Across Service Methods

  • teleivo <mrteleivo@gmail.com>

    teleivo <mrteleivo@gmail.com> 13a93b8ff65ec797c24ba4de5fc9557c78d90d9d

    RAD-332 Fix Transactions Across Service Methods
    Spring advises to annotate only concrete classes with @Transactional

    * remove @Transactional from our Service interfaces
    * add class level @Transactional(readOnly=true) to our Service implemenations at class level
    * override @Transactional(readOnly=true) for methods which are not-read only
    * remove @Transactional from private method RadiologyOrderServiceImpl.saveRadiologyOrderEncounter
    since it has no effect

    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderService.java (version 13a93b8ff65ec797c24ba4de5fc9557c78d90d9d)
    • api/src/main/java/org/openmrs/module/radiology/order/RadiologyOrderServiceImpl.java (version 13a93b8ff65ec797c24ba4de5fc9557c78d90d9d)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportService.java (version 13a93b8ff65ec797c24ba4de5fc9557c78d90d9d)
    • api/src/main/java/org/openmrs/module/radiology/report/RadiologyReportServiceImpl.java (version 13a93b8ff65ec797c24ba4de5fc9557c78d90d9d)
    • api/src/main/java/org/openmrs/module/radiology/study/RadiologyStudyService.java (version 13a93b8ff65ec797c24ba4de5fc9557c78d90d9d)
    • api/src/main/java/org/openmrs/module/radiology/study/RadiologyStudyServiceImpl.java (version 13a93b8ff65ec797c24ba4de5fc9557c78d90d9d)