openmrs-core

• 

  Ivo Ulrich <teleivo@users.noreply.github.com> 31 Dec 2017 dd2767b062459da89763b964d546fdffd2fc31bf

  Merge pull request #2540 from teleivo/TRUNK-5147
  TRUNK-5147 Refactoring VisitServiceTest
• 

  teleivo <mrteleivo@gmail.com> 31 Dec 2017 7ccdd102999819e24534c780b9a2ab942329c199

  TRUNK-5147 Use java.util.Calendar month constants instead of literals

  • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version 7ccdd102999819e24534c780b9a2ab942329c199)
• 

  teleivo <mrteleivo@gmail.com> 31 Dec 2017 b90b7a4c8e0826e78613eeb542a64037bfc3085f

  TRUNK-5147 Remove wrong test javadocs
  removed javadocs above tests which were wrong since the method signature
  of the method they are testing changed.
  
  these javadocs do not provide more information anyway than the test
  itself, are just taking up space and are never updated as can be seen.

  • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version b90b7a4c8e0826e78613eeb542a64037bfc3085f)
• 

  teleivo <mrteleivo@gmail.com> 31 Dec 2017 8087ea3c5fd3020089262bf86aa62c1c3c7a8988

  TRUNK-5147 Extract getting number of all visits in helper
  remove duplication in tests by extracting a helper method for getting
  all visits including voided

  • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version 8087ea3c5fd3020089262bf86aa62c1c3c7a8988)
• 

  teleivo <mrteleivo@gmail.com> 31 Dec 2017 5a8cb37b647db431b40073ac53a55d012b62e5b2

  TRUNK-5147 Split VisitServiceTests for getType/s/ByUuid
  Split tests for when something is found for a given argument and when it
  is not since they represent different cases.
  
  and add static import for assertNull

  • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version 5a8cb37b647db431b40073ac53a55d012b62e5b2)
• 

  teleivo <mrteleivo@gmail.com> 31 Dec 2017 ad24fea21cdcb1a7c253dfa345aa77a0b1bfd58c

  TRUNK-5147 Make use of VisitService field in tests
  VisitService is declared as field in VisitServiceTest and populated with
  Context.getVisitService() before every test but still
  Context.getVisitService() is used instead of the field.
  
  use the field to increase readability

  • api/src/test/java/org/openmrs/api/VisitServiceTest.java (version ad24fea21cdcb1a7c253dfa345aa77a0b1bfd58c)